Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemProvider can't handle escaped strings #352

Closed
1c3f0x84 opened this issue Aug 28, 2019 · 4 comments
Closed

FileSystemProvider can't handle escaped strings #352

1c3f0x84 opened this issue Aug 28, 2019 · 4 comments

Comments

@1c3f0x84
Copy link

1c3f0x84 commented Aug 28, 2019

Describe the bug
FileSystemProvider can't handle escaped strings.

To Reproduce
Steps to reproduce the behavior:

  1. Create a WebServer with WithStaticFolder
  2. Navigate to a folder with a whitespace in it

Expected behavior
To load the index.html in the folder which has a whitespace in it

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: 3.0.2

How to FIX
Add this line
urlPath = Uri.UnescapeDataString(urlPath);
in the Method MapUrlPath(...) in the try block in the file FileSystemProvider.cs

Wanted to do it myself but didn't have any rights to push a branch or PR

@1c3f0x84 1c3f0x84 changed the title FileSystemProvider can't handle scaped strings FileSystemProvider can't handle escaped strings Aug 28, 2019
@geoperez
Copy link
Member

Hi @1c3f0x84 , thanks for the heads up. I'll create the PR with the fix.

The next time, if you want to create a new PR, you need to fork this repository and then modify it to request the PR. It's really easy. In fact, you can try the web editor to start the fork/pr process.

@geoperez
Copy link
Member

You can check the PR!

@1c3f0x84
Copy link
Author

@geoperez thank you for the fast responce and thx for the instruction. I will remember it.

geoperez added a commit that referenced this issue Aug 29, 2019
* Update FileSystemProvider.cs

* Update FileSystemProvider.cs

* Add Unit test

* Update README.md

* Update EmbedIO.csproj
@geoperez
Copy link
Member

The new nuget was published, you can check version 3.0.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants