-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change memory monitor default to false #35
Comments
I agree 100%. Mobile operating systems are designed to make efficient use of available memory. They tend to keep the RAM as full as possible for the sake of performance. Besides, the concept of "start memory" (memStart) is also misleading, as the memory management in mobile devices is dynamic, and there's no such thing as a "fixed initial amount of memory" that an app has after launching it. The criterias for when to trigger the restart/reboots are also based on arbitrary thresholds and ratios. Different hardwares allocate RSS ammounts according to several variables, meaning this would require different parameters for each, so it's not even an universally applicable solution for all use cases. I think this feature focuses too much on treating the symptoms of an issue rather than identifying and addressing the underlying causes (such as memory leaks or inneficcient memory usage). |
This was a sticking-plaster solution which was based around the prevalent mitm architecture and recognition that the third party libraries connected to in the mitm leak over time. There are other architectural solutions which can solve the issue but I am not aware of these being used in any public MITM. |
Resolved in #39 |
Default.json should have memory monitor as false; this monitoring causes confusion in many cases and should likely be 'opt in'
The text was updated successfully, but these errors were encountered: