Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveId doesn't work as expected when query params contains .s #322

Closed
5 tasks done
panchaow opened this issue Nov 12, 2023 · 1 comment · Fixed by #324
Closed
5 tasks done

resolveId doesn't work as expected when query params contains .s #322

panchaow opened this issue Nov 12, 2023 · 1 comment · Fixed by #324
Assignees
Labels
bug Something isn't working

Comments

@panchaow
Copy link

panchaow commented Nov 12, 2023

Describe the bug

It's related to the following lines:

const res = normalizeIconPath(id)
.replace(/\.\w+$/i, '')
.replace(/^\//, '')

extension removal should not be applied on id directly.

Reproduction

try import IconRss from '~icons/lucide/rss?width=1.25rem&height=1.25rem'

System Info

System:
    OS: macOS 13.6.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 71.93 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 19.1.0 - ~/.nvm/versions/node/v19.1.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v19.1.0/bin/yarn
    npm: 8.19.3 - ~/.nvm/versions/node/v19.1.0/bin/npm
    pnpm: 8.6.3 - ~/Library/pnpm/pnpm

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@userquin
Copy link
Member

@userquin userquin added the bug Something isn't working label Nov 12, 2023
@userquin userquin self-assigned this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants