Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom external collection packages #342

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 26, 2024

Description

@iconify/utils from v2.1.20 exposes a new CustomIconLoader to allow load icons from custom external collection packages, this PR just adds the helper and the corresponding entry in the readme file.

@antfu should we cleanup types and update TS to 5.3.3?

Linked Issues

Additional context

iconify/iconify#276

Copy link

stackblitz bot commented Jan 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

socket-security bot commented Jan 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@iconify/utils@2.1.20 Transitive: environment, filesystem, shell +29 1.47 MB cyberalien

🚮 Removed packages: npm/@iconify/utils@2.1.12

View full report↗︎

@userquin userquin requested a review from antfu January 26, 2024 20:04
@userquin userquin marked this pull request as ready for review January 26, 2024 20:04
@userquin userquin merged commit dbe23c6 into main Jan 26, 2024
2 checks passed
@userquin userquin deleted the userquin/feat-include-new-iconify-options branch January 26, 2024 21:20
@userquin userquin restored the userquin/feat-include-new-iconify-options branch January 26, 2024 21:20
@userquin userquin deleted the userquin/feat-include-new-iconify-options branch January 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant