fix(vite-vue3): update include regex to support production build #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Aug 21, 2023
antfu
changed the title
|
Thanks for suggestion and merging.This is my first merged pr. @antfu |
sxzz
pushed a commit
that referenced
this pull request
Aug 30, 2023
sxzz
pushed a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
problem: .The problem just belongs to examples/vite-vue3. There is no component in web page after running 'pnpm build' and 'pnpm preview'
process: After running 'pnpm build', the path '...ComponentA.vue' will become '...ComponentA.vue?vue&type=script&setup=true&lang.ts'. But vite config option 'include' do not include this situation. So I think it's time to change 'include' option's regex. The soluation case is the same as 'core/unplugin.ts'.
Linked Issues
#503
Additional context
Although I soluation the probleam, I don't know the process that the path '...ComponentA.vue' will become '...ComponentA.vue?vue&type=script&setup=true&lang.ts'.