Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element-plus): handling components without styles #468

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

dblazhkun
Copy link
Contributor

Description

Element Plus can contain components without css files. There seems to be only one such component right now, ElAutoResizer. Now it comes to an error of loading un-existed styles file.
This PR adds a list of components without styles that can be updated later, and toggles the importStyle flag to false for them.

Linked Issues

element-plus/element-plus#7933

@dblazhkun dblazhkun requested a review from sxzz as a code owner July 19, 2022 10:52
@sxzz sxzz changed the title fix: handling components without styles for ElementPlusResolver fix(element-plus): handling components without styles Jul 19, 2022
@sxzz sxzz merged commit bc84c88 into unplugin:main Jul 19, 2022
@btea
Copy link
Contributor

btea commented Jul 20, 2022

Maybe can add a noStylesComponent option for users to configure themselves.

@dblazhkun
Copy link
Contributor Author

Maybe can add a noStylesComponent option for users to configure themselves.

I think this would be handy for getting around such blocking cases quickly without having to wait for a new release of unplugin-vue-components. On the other hand, it seems useful to keep a list of already known components without styles inside the resolver. I suggest combining support for both options.
Will make an additional PR for this.

@btea
Copy link
Contributor

btea commented Jul 21, 2022

You are so efficient, it's amazing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants