Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update buttons for non-dockerman containers #1582

Merged
merged 1 commit into from Feb 15, 2024

Conversation

mtongnz
Copy link
Contributor

@mtongnz mtongnz commented Jan 12, 2024

Remove the update/force update buttons from the GUI for non dockerman containers. Pressing them results in an error and updates for these containers should be done by the appropriate manager.

@bergware
Copy link
Contributor

This looks good, thanks

@limetech limetech merged commit 3b60e15 into unraid:master Feb 15, 2024
@ashishpandey
Copy link

ashishpandey commented Feb 25, 2024

does this only remove the buttons from UI, or would this also handle fix common problems from reporting update being available? Ideally, it would be nice if the update available state isnt computed at all

@mtongnz
Copy link
Contributor Author

mtongnz commented Feb 27, 2024

does this only remove the buttons from UI, or would this also handle fix common problems from reporting update being available? Ideally, it would be nice if the update available state isnt computed at all

This only removes the buttons.
The "updates available" is to do with how unraid stores the current version of each installed container. If you're using Compose Manger, I submitted a PR which hasn't been implemented yet: dcflachs/compose_plugin#25

@mtongnz mtongnz deleted the manager-fixes branch April 5, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants