-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Error Correction Type information #176
Conversation
It would be great to start integrating ECC/EDAC support to unRAID, one of the first steps might be the relevant information from the BIOS/UEFI. It would be good to reduce the `dmidecode -t 16` calls to one, I'm not aware if `Maximum Capacity` and `Error Correction Type` can be extracted with `awk` in one go without having to `explode` the row, otherwise it would be fine.
Just a update: I'm enabling EDAC support in the linux kernel |
@eschultz, good to know. Is this expected to be available in the next RC? Looking forward to testing this on an ECC enabled X370 platform. |
@realies We jumped up to kernel 4.13.4 and added EDAC so if the new kernel checks out (i'm sure it will) then it'll all be included in the next RC. Kernel 4.12.x is EOL now. |
You can combine both searches in a single awk statement. Like this
And make a single echo statement. Like this
|
Since the output of |
// If maximum < installed then roundup maximum to the next power of 2 size of installed. E.g. 6 -> 8 or 12 -> 16 | ||
if ($memory_maximum < $memory_installed) {$memory_maximum = pow(2,ceil(log($memory_installed)/log(2))); $star = "*";} | ||
echo "$memory_installed GB (max. installable capacity $memory_maximum GB)$star"; | ||
$star = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line was meant to initialize $star, it should come before line 145.
It would be great to start integrating ECC/EDAC support in unRAID, one of the first steps might be to display relevant information from the BIOS/UEFI.
Reducing the
dmidecode -t 16
calls to one is preferable, I am not aware ifMaximum Capacity
andError Correction Type
can be extracted withawk
in one go without having toexplode
the row as done with$cache
, otherwise it would be fine.