Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app icons container slidedown speed #290

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

realies
Copy link
Contributor

@realies realies commented Mar 12, 2018

Ain't nobody got time for that

ain't nobody got time for that
@bergware
Copy link
Contributor

Do you have a long list of containers + vms?

@realies
Copy link
Contributor Author

realies commented Mar 12, 2018

Further investigation shows that the DockerClient.getAllInfo() method takes more than 2000ms to complete on the 32 container instance I'm running. Further delaying the slideDown speed makes it unpleasant to watch.

@realies
Copy link
Contributor Author

realies commented Mar 12, 2018

Commenting out https://github.com/limetech/webgui/blob/fa8b4a931b01142ada2c2c02fa101cd52ac0a30e/plugins/dynamix.docker.manager/include/DockerClient.php#L327-L341 produces a consistent loading time reduction for DockerClient.getAllInfo() by about 1800ms.

@realies
Copy link
Contributor Author

realies commented Mar 12, 2018

For 32 container instances DockerClient.getIcon() takes about 150ms, DockerClient.getControlURL() about 1150ms and populating $Registry, $Support, $Project takes about 400ms. DockerClient.getTemplateValue() seems to be going through all template files every time it's being called. Perhaps load that data into memory and retrieve from there instead.

@bergware
Copy link
Contributor

My case:
I have 9 containers + 3 VMs. The complete rendering takes 517 ms.
Your hardware plays a role too!

@limetech limetech merged commit 5b1298c into unraid:6.4-wip Mar 12, 2018
@realies
Copy link
Contributor Author

realies commented Mar 13, 2018

@bergware, figured out it is actually 32 containers with 21 being on. Wonder what would be a good way to speed this up. Is /usr/local/emhttp/* living in tmpfs @limetech?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants