Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webredir by single quotes #208

Conversation

ZarTek-Creole
Copy link
Contributor

need single quotes rather than double quotes because unreal will try to download.need single quotes rather than double quotes because unreal will try to download. Try error with "http://www.extra-cool.fr"

[25-05/23:43] Hi, an little bug in set { webredir { url "https://www.extra-cool.fr/"; } } return "set::webredir::url needs to be a valid URL" because contains an " - " in domain name. I don't know why he rejected on the condition: if (!strstr(cep->value, "://") || !strcmp(cep->value, "https://..."))
[25-05/23:49] UnrealIRCd-6.0.3.
[25-05/23:51] ZarTek, you may need single quotes there rather than double quotes, as unreal will try and download the page and use /that/ as the value if it's double i think
[25-05/23:54] * Joins: sAn (~sAn@Clk-EC2D4344.clients.your-server.de)
[25-05/23:55] alice: It seems very possible to me. I'll try. Thank you for your reply.
[25-05/23:56] <@valware> =]
[25-05/23:58] Yes, it works, very good deductions from you. Although such behavior was unexpected in this value.
[26-05/00:07] <@valware> indeed, on the wiki it has specified with double-quotes when in fact it expects single-quotes to work. so I edited it :D
[26-05/00:07] <@valware> https://www.unrealircd.org/docs/Set_block#set::webredir::url
[26-05/00:07] <@valware> =]

syzop added a commit that referenced this pull request May 26, 2022
@syzop
Copy link
Member

syzop commented May 26, 2022

It seems this PR accidentally inherited the work on history.conf too, so I cannot apply it individually. Anyway, not important, on to the point...

Indeed you are right, it should have single quotes. Without single quotes it would cause a confusing error. So thanks for that! Done in 82063a4

@syzop syzop closed this May 26, 2022
@ZarTek-Creole ZarTek-Creole deleted the fix_webredir_double_quotes branch May 27, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants