-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOGOUT command #231
LOGOUT command #231
Conversation
This creates LOGOUT command which logs a user out independent of services. It will also send out an SVSLOGIN so that services correctly implementing SVSLOGIN (for configurations of multiple SASL-servers) will be able to know that the user is logged out.
Worth noting, a quick conversation with Sadie from Anope said that they don't process incoming Dalek seems to be the only supporting services package. That said, I will work to try and make pull requests for both Anope and Atheme for implementing this. Whether or not they will be accepted is another story, but I can't imagine it would hurt their services to include support for it. |
Made it so that it will check if NIckServ is online (and part of the config-defined `services-server` and ask it to log us out. If it's not, then we still logout and assume that services will see that we are logged out when they catch up again.
Made this work a bit neater for existing services, the biggest snag is we have to fail it at the end if there was no NickServ on the services server, because we don't want to desync services. This feels kinda messy as we shouldn't be messaging a bot about it really, since there is never a guarantee that the bot with the logout command is called NickServ. |
I like the idea. I mean: via SASL we allow logging into an account without knowing anything about services, but there is no way to log out of it without knowing anything about services. Surely we won't be the only one who wants/needs this, you are coordinating with others, right? Keep us updated :) |
…vices can handle it
Atheme PR requested and mentioned so both can see what I'm trying to achieve here |
Anope has now implemented support for server-side logout 😄 |
Just an update here, so everyone can see it: So, we will wait a while, I don't know the schedule about anope 2.1.x but it sounds like something that will not be out very soon. Ah well, we can wait, this is nice functionality but missing it not life threatening :). |
This creates LOGOUT command which logs a user out independent of services. It will also send out an SVSLOGIN so that services correctly implementing SVSLOGIN (for configurations of multiple SASL-servers) will be able to know that the user is logged out.