Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain GENCERTIFICATE value before writing config.settings #256

Merged
merged 1 commit into from Aug 19, 2023

Conversation

netjester
Copy link
Contributor

@netjester netjester commented Aug 16, 2023

Relates to https://bugs.unrealircd.org/view.php?id=6328

Solves the problem by moving the initial question about whether to generate a self-signed SSL cert to a point earlier in the process.

Actual generation of the cert (and associated property questions) remain at the end of the process.

The question now appears immediately after the "path to OpenSSL/LibreSSL" question, as it seemed like a reasonably logical place in the sequence for it to go.

@syzop syzop merged commit f756b7b into unrealircd:unreal60_dev Aug 19, 2023
@syzop
Copy link
Member

syzop commented Aug 19, 2023

Thanks! :)

@syzop
Copy link
Member

syzop commented Nov 4, 2023

Hm, this breaks the check for if tls/server.cert.pem already exists, because CONFDIR is not set yet. So it prompts all users who have a cert already too. Will take a look later.

@syzop
Copy link
Member

syzop commented Nov 4, 2023

Ok, fixed that in ec4e1d9. Issue only affected 6.1.2 and well... even if you answered Yes to the prompt it was pretty harmless since it would skip cert generation at the end anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants