This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Fix StreamMatchers.equalTo() types #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the correct parameterised type.
This is peculiar. It seems the type inference through multiple levels of method invokations is better with Java 8 than Java 11. Anyway, the outermost is(..) invocation is redundant (and in my opinion also decreases readability), so they are removed to make the code compile on Java 11.
This was referenced Apr 15, 2020
|
Looks good but we have no build status. What happened to Travis? |
|
I had to do some changes in #23 to get the Travis build to work for my fork Build on Travis on OpenJDK 8 (rationale in commit message) 1070dd7 Other changes in .travis.yml |
|
Hi Clive, Rune,
I hope to make some time today or tomorrow to follow up There are some
policy changes at Unruly which mean I'd like to add non-Unruly employees to
the committer/releaser group. I'd like you thoughts on suitable candidates
- you may nominate yourselves if you like!
…--bruce
On Wed, 13 May 2020, 09:11 CliveEvans, ***@***.***> wrote:
Looks good but we have no build status. What happened to Travis?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPBBC5U22EUB3MDTAQ7ON3RRJI3XANCNFSM4MGBBHFA>
.
|
|
Great! |
|
I'm happy to come back on board ;-) |
Ok, let's get that one in first then. looks meaningfully at @bruceeddy |
This was referenced Jul 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small addition to #19 to fix some typing. Se discussion here #18 (comment)
Fixes #18