Skip to content

Commit

Permalink
[fix] Fix ftp port
Browse files Browse the repository at this point in the history
  • Loading branch information
lpinca committed Oct 30, 2015
1 parent 0fad9a3 commit 4c52b7b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -25,7 +25,7 @@ module.exports = function required(port, protocol) {
return port !== 443;

case 'ftp':
return port !== 22;
return port !== 21;

case 'gopher':
return port !== 70;
Expand Down
10 changes: 5 additions & 5 deletions test.js
Expand Up @@ -72,11 +72,11 @@ describe('requires-port', function () {
assume(required(8080, 'wss://www.google.com')).true();
});

it('does not require port 22 for ftp', function () {
assume(required('22', 'ftp')).false();
assume(required(22, 'ftp')).false();
assume(required(22, 'ftp://')).false();
assume(required(22, 'ftp://www.google.com')).false();
it('does not require port 21 for ftp', function () {
assume(required('21', 'ftp')).false();
assume(required(21, 'ftp')).false();
assume(required(21, 'ftp://')).false();
assume(required(21, 'ftp://www.google.com')).false();

assume(required('8080', 'ftp')).true();
assume(required(8080, 'ftp')).true();
Expand Down

0 comments on commit 4c52b7b

Please sign in to comment.