Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1 - Fix always empty landmark columns #16

Merged
merged 3 commits into from Aug 12, 2020
Merged

Conversation

TimmyCarbone
Copy link
Member

@TimmyCarbone TimmyCarbone commented Aug 11, 2020

Overview

New release

  • Upon merging, create a 1.0.1 tag and release for the dataset.
  • /lite/latest API link updated to the 1.0.1 dataset.

@TimmyCarbone TimmyCarbone added the bug Something isn't working label Aug 11, 2020
@TimmyCarbone TimmyCarbone self-assigned this Aug 11, 2020
@TimmyCarbone TimmyCarbone added this to In progress in 1.0.1 via automation Aug 11, 2020
@lukechesser
Copy link
Member

@TimmyCarbone did this just apply to the lite dataset or the full as well?

@TimmyCarbone
Copy link
Member Author

TimmyCarbone commented Aug 12, 2020

@lukechesser This applies to both. A new version of the 2 datasets has been generated. I think whatever applies to one dataset should apply to the other (under the same version).

@lukechesser
Copy link
Member

@TimmyCarbone gotcha, thanks, just wanted to make sure for the changelog 👍

@unsplash unsplash deleted a comment from mizzbbee8778 Aug 12, 2020
@unsplash unsplash deleted a comment Aug 12, 2020
@TimmyCarbone TimmyCarbone merged commit f7d6a18 into master Aug 12, 2020
1.0.1 automation moved this from In progress to Done Aug 12, 2020
@TimmyCarbone TimmyCarbone deleted the bug/empty-landmarks branch August 12, 2020 17:22
@unsplash unsplash deleted a comment Aug 12, 2020
@unsplash unsplash deleted a comment from mizzbbee8778 Aug 12, 2020
@unsplash unsplash deleted a comment from mizzbbee8778 Aug 12, 2020
@unsplash unsplash deleted a comment from mizzbbee8778 Aug 12, 2020
@unsplash unsplash locked as resolved and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
1.0.1
  
Done
Development

Successfully merging this pull request may close these issues.

Is it expected to have fields where all values are null
2 participants