Maintenance: CLI release #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhh
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Works on my machine, looks good!
Long-term I'm a little nervous about dynamic linking, I've had some trouble there before and static linking isn't easy to set up, but it seems to be working. Maybe in practice that's only an issue in very slim environments like AWS. 🤷
|
To be clear, we'll need to push a tag to create the release. We could automate this step during the PR process. e.g a commit that changes some version somewhere but for now it'll have to be done manually |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example release https://github.com/unsplash/intlc/releases/tag/v0.1.0
Let me know what you think