Add golden/snapshot testing #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35. Thanks @Magellol for your initial outlay!
This PR adds golden/snapshot testing with an example test migration included. There's no longer any need to write the expected output code, merely verify prior to committing that it looks correct.
It outputs
.tsfiles, so we get syntax highlighting and per @Magellol's suggestion in the linked issue we could pursue typechecking these perhaps as a CI step. If a test fails the output will be the printed error(s).I believe the gitignore pattern is safe provided we always include an
actualprefix in ouractualFileoutputs.