Refactor: PR #1 feedback #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samijaber
commented
Jun 8, 2018
| export const progressivelyEnhance = function<Props>(ComposedComponent: React.ComponentType<Props>) { | ||
| export const progressivelyEnhance = <Props extends {}>( | ||
| ComposedComponent: React.ComponentType<Props>, | ||
| ) => { |
There was a problem hiding this comment.
To use generics with arrow functions in .tsx files, we have to do make the generic extend another type. This is so that TypeScript knows it's looking at a generic and not a JSX tag. Otherwise, the syntax will be ambiguous to the compiler 😕
OliverJAsh
approved these changes
Jun 11, 2018
| .vscode | ||
| .github | ||
| .editorconfig | ||
| .prettierrc |
There was a problem hiding this comment.
Instead of .npmignore you can specify a files whitelist inside package.json. Depends what you prefer!
| @@ -6,16 +6,14 @@ indent_size = 2 | |||
| trim_trailing_whitespace = true | |||
There was a problem hiding this comment.
Maybe a comment at the top to say that Prettier will inherit from here? E.g. https://github.com/unsplash/web-ops/blob/7352b543ae110247b005cb60226c6adf213401b1/.editorconfig#L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview