Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per page param #36

Merged
merged 3 commits into from
Feb 13, 2017
Merged

Per page param #36

merged 3 commits into from
Feb 13, 2017

Conversation

gustavosobral
Copy link
Contributor

@gustavosobral gustavosobral commented Feb 12, 2017 •
edited

Hi guys, thanks for the awesome job with the Unsplash platform. This PR allows User, Collection and Photo search method receive number of elements per_page param. As follow:

collections = Unsplash::Collection.search('explore', 1, 25)
users = Unsplash::User.search('ches', 1, 30)
photos = Unsplash::Photo.search('dog', 1, 3)

Since that the params api_base_uri andoauth_base_uri of Unsplash::Connection on spec helper points to some server running local, based on #26 PR solution, I've added three new requests for VCR cassettes used on these specs.

Let me know if there is something to improve, thanks!

@aaronklaassen aaronklaassen merged commit cfd6e55 into unsplash:master Feb 13, 2017
@aaronklaassen aaronklaassen mentioned this pull request Feb 13, 2017
Closed
@gustavosobral gustavosobral deleted the per_page_param branch February 27, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gustavosobral @aaronklaassen