Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #68

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Update README.md #68

merged 1 commit into from
Apr 25, 2019

Conversation

equivalent
Copy link
Contributor

Overview

documentation is missing how to trigger "track download"

@aaronklaassen
Copy link
Member

aaronklaassen commented Apr 5, 2019

Thanks @equivalent - you're right this should be in the readme. Your second commit here (that adds the http call) isn't necessary though. Photo#track_download does the GET:

def track_download
connection.get(links.download_location)["url"]
end

As for the broken build I think that's just a configuration issue. I'll take a look.

@equivalent
Copy link
Contributor Author

@aaronklaassen Hi I've removed last commit

sorry for delay

@aaronklaassen aaronklaassen merged commit d2b3f17 into unsplash:master Apr 25, 2019
@equivalent equivalent deleted the patch-1 branch April 25, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants