Improve more projects section #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokwejuste
approved these changes
Feb 1, 2024
|
the code looks good. Still need to manually test the PR |
NdibeRaymond
force-pushed
the
improve-more-projects
branch
2 times, most recently
from
88c9daf
to
3c6a3ce
Compare
|
pre-commit checks failed ❌❌❌ |
* create views and utils methods to recommend projects * create api function to receive recommended projects in the frontend * modify project filtering * refactor recommend projects function Issue: #1013 Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond
force-pushed
the
improve-more-projects
branch
from
3c6a3ce
to
7ce8ea5
Compare
|
All pre-commit checks passed ✅✅✅ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
'More Projects' section used to show the projects of the same user instead of showing similar projects from any user. With this PR, this section sends a request to the backend with the current project's id and retrieves 3 recommended projects depending on the project's categories.
Closes #1013
The changes in backend is adapted from @anthonycruzmacedo 's code in #458
Changes
Frontend
projects/${id}/recommend/getMoreProjectsfunctionprojectDetails.jsxusesgetMoreProjectsto render the recommended projectsBackend
'<uuid:pk>/recommend/'url is used to recommend projectsProjectRecommendAPIViewclass returns 3 recommended projectsrecommend_projectsfunction handles the logic to determine the 3 projects by checking the projects with the same category/categories, and show the most liked projects if there's none.Screenshots
Before
After
Update
With the updated function, the projects are filtered based on their title, tags and categories. When doing title check, the project title is converted into an array of strings and each word is mapped. If any of the words are found in other titles, the project is appended. I will refer to these projects with 'similar title' in this PR.
First loop is done with the similar titled projects, looking for:
Second loop looks for projects with:
Third loop looks for the most liked projects