Recommend Projects View and URL #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject user is viewing, create helper methods for view in utils, create url to call view
anthonycruzmacedo
requested review from
NdibeRaymond,
tuxology and
ajain1921
as code owners
ajain1921
reviewed
Apr 29, 2022
Comment on lines
+370
to
+371
| if len(projects) == 3: | ||
| return projects |
There was a problem hiding this comment.
idt this check is needed. the length should only change after an append
Comment on lines
+358
to
+365
| for j in Project.objects.filter(category__name=category).order_by('?'): | ||
| tags_j = list(j.tags.all()) | ||
| # skip original project and any projects already added to projects | ||
| if j == project or j in projects: | ||
| continue | ||
| # if the jth project's tags include the ith tag, add to projects | ||
| if i in tags_j: | ||
| projects.append(j) |
There was a problem hiding this comment.
In order to make this a little cleaner and prevent redundant checks, we can get all the projects that are PUBLIC and that aren't the project that was passed into the function with a filter query at the top. Then all subsequent filters can be done on that. This would remove the need for the 361 check and also ensure we aren't looking at projects that are drafts. Also we can add a filter to 358 that also ensures that the projects have tags that include the ith tag. Check this for more info. This would also remove the need for the 364 line.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create ProjectRecommendAPIView and endpoint to recommend 3 projects based on:
Closes #417
Changes