(feat) Add login modal when searching projects for non-authenticated users #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderatomy
force-pushed
the
search-modal
branch
2 times, most recently
from
bbcbb8b
to
f14ae18
Compare
coderatomy
force-pushed
the
search-modal
branch
from
f14ae18
to
04b5a5a
Compare
coderatomy
changed the title
coderatomy
force-pushed
the
search-modal
branch
from
04b5a5a
to
a6fc96a
Compare
|
Hey @coderatomy, thanks for redoing this 👍 I tried to test this and was unable to get the featured projects show up on test instance (behind the modal) when I searched as non-logged in user. Here is an example:
The project does exist and is marked as featured project 👇
|
tuxology
requested changes
Nov 21, 2023
| @@ -282,6 +330,9 @@ const mapStateToProps = state => { | |||
|
|
|||
| const mapDispatchToProps = dispatch => { | |||
| return { | |||
| getStaffPicks: args => { | |||
There was a problem hiding this comment.
I see that we are only getting staff picks, but even when staff pics are enabled, we are not rendering. What could be the issue? Can you test locally and make changes if needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds login modal for non-authenticated users
Closes #802
Changes
featured projectsScreenshots