Replace server context with AsyncLocalStorage and client context
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Because [server context has been deprecated](facebook/react#27424), we needed to find a replacement for sharing the current location. Using conditional exports, we can create a universal `useRouterLocation` hook that utilizes `AsyncLocalStorage` on the server, and normal client context in the browser. Even though the client context would also be accessible in the SSR client (we could render the context provider in `ServerRoot`), we are instead using `AsyncLocalStorage` here as well, primarily for its convenience. Although this does require placing the module containing the `AsyncLocalStorage` instance into a shared webpack layer.
unstubbable
force-pushed
the
replace-server-context
branch
from
0219e49
to
8f840e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because server context has been deprecated, we needed to find a replacement for sharing the current location.
Using conditional exports, we can create a universal
useRouterLocationhook that utilizesAsyncLocalStorageon the server, and normal client context in the browser. Even though the client context would also be accessible in the SSR client (we could render the context provider inServerRoot), we are instead usingAsyncLocalStoragehere as well, primarily for its convenience. Although this does require placing the module containing theAsyncLocalStorageinstance into a shared webpack layer.