Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Open In" for a few Mastodon clients #7

Merged
merged 6 commits into from
May 4, 2024

Conversation

ZackBoe
Copy link
Contributor

@ZackBoe ZackBoe commented May 2, 2024

Hey! Thanks for building & hosting this, it's really improved my Mastodon usage.

This adds an Open In link for a couple of clients, in addition to the Original Mastodon Post link. I really like this in @tvler's StreetPass, so thought I'd add take a shot at adding it here. I'd add more clients, but Ivory seems to be the only one that has a page on its scheme and I don't have an iPhone to test.

I'd like to add a little dropdown on the results page to optionally add one of the known client query params.

firefox_2024-05-01_23-31-59

This is the first time I've done anything in Rust, so hopefully it looks alright. I had some confusion between String and str.

@untitaker
Copy link
Owner

untitaker commented May 2, 2024

So there are a couple of apps that do this already:

  • Fediverse Redirector literally handles all mastodon urls to implement this for Android
  • there is at least one browser extension for it on desktop

I acknowledge that Ivory/iOS may be unsolved.

Do none of these work for you?

I am not fully opposed to adding this sort of functionality to bookmark-rss, as my own experience with those extensions has been somewhat underwhelming as well, and the browser extension in particular requires a large amount of permissions.

The code itself looks fine to me.

@ZackBoe
Copy link
Contributor Author

ZackBoe commented May 2, 2024

My personal use case for this is opening the bookmarked post in my client of choice from a web or desktop RSS reader to like/reply/etc. I haven't revisited any redirector extensions in some time, but I generally wasn't a fan of how they functioned and mostly prefer direct links.

@ZackBoe
Copy link
Contributor Author

ZackBoe commented May 3, 2024

I've added few more clients and a select to the results page, though I feel even less confident I've done this in the best way in Svelte.

firefox_2024-05-02_23-52-00

@ZackBoe ZackBoe marked this pull request as ready for review May 3, 2024 03:55
@untitaker untitaker merged commit a340576 into untitaker:main May 4, 2024
1 check passed
@untitaker
Copy link
Owner

thank you, I will push it in a second

@untitaker
Copy link
Owner

deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants