Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying dependency on Rails #19

Open
Bounga opened this issue Mar 8, 2017 · 0 comments
Open

Annoying dependency on Rails #19

Bounga opened this issue Mar 8, 2017 · 0 comments

Comments

@Bounga
Copy link

Bounga commented Mar 8, 2017

Hello.

"mina-puma" requires mina/rails and it's pretty annoying and can cause bugs when using other plugins.

I use "mina-hanami" and there are some conflicting tasks such as mina console since these are not namespaced. So if one requires "mina-puma" after "mina-hanami" these tasks are overwritten.

I think it's a bit useless to require mina/rails to set puma_env (that you can default to production without trying to get RAILS_ENV value) and gain access to bundle_prefix you could easily rewrite with something like:

set :bundle_prefix, -> { %{#{fetch(:bundle_bin)} exec} }

and let the user knows he can tune it or even require mina/rails, mina/hanamior mina/whatever_framework after mina/pumato get this set for him.

My point here is it would be great if "mina-puma" was framework agnostic. What do you think of this idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant