Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: drop bluebird and leverage async/await #64

Open
rijnhard opened this issue Feb 18, 2021 · 3 comments
Open

Suggestion: drop bluebird and leverage async/await #64

rijnhard opened this issue Feb 18, 2021 · 3 comments

Comments

@rijnhard
Copy link
Contributor

rijnhard commented Feb 18, 2021

This is probably the least important issue but figured we can discuss it anyway.

All the current stable versions of node and browsers support promises and bluebird is not a dependency that libraries should ship with if it can be avoided.

the codebase itself could really benefit from cleanup and a switch to native promises and async/await.

I don't see this adding much value other than decreasing the likelihood of silly errors like #62 and general code legibility (promises with callbacks tend to be less legible in most circumstances than the equivalent async/await).

P.S. I am aware that not ALL promise usages should be transferred to async/await, especially for concurrency but most of the functions tend to be step by step inside anyway.

@weekens
Copy link
Contributor

weekens commented Feb 24, 2021

Thank you, @rijnhard , that's a good idea I think!

@islomkhodja
Copy link

@weekens if I have time after hours I can help with this migration

@weekens
Copy link
Contributor

weekens commented Feb 4, 2022

@islomkhodja You could try to! But this is not an easy task at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants