Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(in-memory-actor) emits warning about promise handler #62

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

rijnhard
Copy link
Contributor

if you run the getting started example with the node --trace-warnings flag it yields the following error Warning: a promise was created in a handler but was not returned from it

this fixes it. I return null instead of the inner P.resolve() because the function originally had no return, so this doesn't introduce any new behaviour.

If it should return a value then I will gladly make the change.

@weekens weekens self-requested a review June 2, 2022 07:56
@weekens weekens merged commit b719ecc into untu:master Jun 2, 2022
@weekens
Copy link
Contributor

weekens commented Jun 2, 2022

Fix released in 2.1.7. Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants