ncurses: handle white backgrounds, too #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
White backgrounds broke with the support of transparency because only the default bg color was considered. The fg color was still hardocded to white, resulting in white on white e.g. for the config screen. So, the default fg color needs also to be considered. Luckily, color pair 0 is set to the default colors after use_default_colors(), so we simply need to map the index for the standard color accordingly. This will also work when transparency is disabled because ncurses initializes color pair 0 to white on black when not calling use_default_colors() which is exactly what we want in this case.
|
Great find. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
White backgrounds broke with the support of transparency because only the default bg color was considered. The fg color was still hardocded to white, resulting in white on white e.g. for the config screen. So, the default fg color needs also to be considered. Luckily, color pair 0 is set to the default colors after use_default_colors(), so we simply need to map the index for the standard color accordingly. This will also work when transparency is disabled because ncurses initializes color pair 0 to white on black when not calling use_default_colors() which is exactly what we want in this case.