fix(api): added error handling for undefined api routes #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siefkenj
reviewed
Jul 22, 2019
| @@ -7,6 +7,10 @@ class ApplicationController < ActionController::Base | |||
|
|
|||
| def index | |||
| render :file => 'public/index.html' | |||
| end | |||
| end | |||
…ror function, and updated jest test to match the status error response
siefkenj
reviewed
Jul 24, 2019
|
|
||
| end | ||
|
|
||
| def not_found |
frontend/src/__tests__/api.test.js
Outdated
| function unknownRouteTests(api = { apiGet, apiPost }) { | ||
| const { apiGet, apiPost } = api; | ||
|
|
||
| it("should succeed GET request with known '/api' routes", async () => { |
There was a problem hiding this comment.
This test is not needed. It is already done elsewhere
frontend/src/__tests__/api.test.js
Outdated
| @@ -352,6 +366,9 @@ describe("API tests", () => { | |||
| describe("`/applications` tests", () => { | |||
| applicationsTests({ apiGET, apiPOST }); | |||
| }); | |||
| describe("`/404` tests", () => { | |||
There was a problem hiding this comment.
Describe these tests better
…, and fixing spacing problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 404 route that matches urls for undefined '/api' routes for the rails backend. Previously, undefined api routes are handled as frontend react router routes and rails would return a 200 status.