Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the copyright statements? #67

Open
sseymore opened this issue Sep 15, 2020 · 7 comments
Open

Where are the copyright statements? #67

sseymore opened this issue Sep 15, 2020 · 7 comments
Assignees
Labels

Comments

@sseymore
Copy link

The copyright statements for each title are not visible from the front-end/public view. Was this lost in the migration? Needs investigation.

@jechols
Copy link
Member

jechols commented Jan 4, 2021

Sorry for the delay, I'm looking into this right now as I try to clear some of my "quick" backlogged to-do items.

It looks like the problem here is entirely on my end, and indeed during the migration. I'm not sure how I missed this stuff, but the copyright data is no longer in the database at all.

I can use NCA's information to determine which titles need data presented, but there's a small problem: for each copyright URI, I need some accompanying text to display. e.g., we'd probably want "Public Domain" for the URI http://creativecommons.org/publicdomain/mark/1.0/.

Here's all the rights URIs we have, and my best guess at the text based on what the URLs point to:

If you can get me the proper text for those, I can get things moving when I have some time.

@sseymore
Copy link
Author

sseymore commented Jan 4, 2021 via email

@jechols
Copy link
Member

jechols commented Jan 4, 2021

The system in ONI can use a date range, but everything prior to 1923 gets forcibly set to being Public Domain so long as that URI is in our database (it currently isn't) . So we'd probably set everything to be a given rights statement from 1923 until basically 9999 or something crazy so it acts as a "forever" date. I think that's what you want, but let me know if not.

@sseymore
Copy link
Author

sseymore commented Jan 4, 2021

I'm not sure I understand. The public domain is now "rolling" every year, so it would be great to add public domain to all issues through the end of 1925 (as of 2021). Then, in 2022, all of the 1926 issues would also enter the PD and get that statement. I realize that's more work-- might just need another ticket for now?

@jechols
Copy link
Member

jechols commented Jan 28, 2021

Sorry for the delay, I saw this and then got sidetracked again on other fires.

I was not aware of the rolling PD date. That definitely complicates things a little, but I think I could submit a change to ONI to handling this logic. It seem like it would be simple enough - if current year minus issue publication year is 96 or greater, it's magically PD regardless of the database rules. Does that seem correct? I'll look into this today.

@sseymore
Copy link
Author

sseymore commented Jan 28, 2021 via email

@jechols
Copy link
Member

jechols commented Jan 29, 2021

The rolling PD (and PD info in general) is fixed via open-oni/open-oni#576, so once that's in ONI and we have another ONI release, we'll be set. Then I can get our title-specific copyright stuff into our local ONI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants