Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp diagnostics must take into account time_offset #41

Merged
merged 1 commit into from Sep 8, 2016

Conversation

procopiostein
Copy link
Contributor

in our setup we have a big time offset due to delay in communications using the USB interface. because of that, the diagnostics fails because the timestamp delay is too big wrt the expected frequency.
with the current fix, the diagnostic_updater take into account the time_offset parameter.

@mintar
Copy link
Member

mintar commented Sep 8, 2016

Thanks! I've just tested your PR and it works as advertised.

The only thing that doesn't work is when you update the time_offset param using dynamic reconfigure after the node has started up, the TimeStampStatusParam won't be updated, but there seems to be no straightforward way to do that using the diagnostics API, so let's leave that for now.

Thanks again!

@mintar mintar merged commit db80e08 into uos:indigo Sep 8, 2016
@procopiostein
Copy link
Contributor Author

thank you!

@procopiostein
Copy link
Contributor Author

do you expect to create a release of the last changes anytime soon? thanks!

@mintar
Copy link
Member

mintar commented Sep 9, 2016

Done!

@procopiostein
Copy link
Contributor Author

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants