Skip to content

Commit

Permalink
Minor modifications to improve SEO and semantics of site (#4129)
Browse files Browse the repository at this point in the history 
* feat: Extended meta description (#1285) Based on description from #2081

* refactor: Removed lists inside p elements (#1285) p elements should not have ul or ol elements as children

* feat: Added semantic html5 elements(#1285)

---------

Co-authored-by: es-rene99 <es.rene99@gmail.com>
  • Loading branch information
@shiftkey @es-rene99
shiftkey and es-rene99 committed Aug 27, 2023
1 parent 004cc7a commit cb4919e
Show file tree
Hide file tree
Showing 6 changed files with 70 additions and 75 deletions.
8 changes: 2 additions & 6 deletions _includes/after.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,23 @@ <h1><span class="header-inside">I maintain a project!</span></h1>
open source.
</p>

<p>
What sort of tasks are a good fit?
<p>What sort of tasks are a good fit?</p>

<ul>
<li>Tasks should take no longer than a few nights' worth of work</li>
<li>Tasks should stand alone - avoid core functionality on which other tasks depend</li>
<li>Tasks should be well described with pointers to help the implementer</li>
</ul>
</p>

<p>
We suggest the label <code>up-for-grabs</code>
but using a different name is also acceptable.
</p>

<p>
If this sounds like you, getting involved is simple:
<p>If this sounds like you, getting involved is simple:</p>

<ol>
<li><a href="https://help.github.com/articles/creating-and-editing-labels-for-issues-and-pull-requests/" title="Creating and editing labels for issues and pull requests">Label</a> bugs and feature requests that would be a good place to start</li>
<li>Grab the URL to this list of tasks so that others can get to it easily</li>
<li><a href="https://github.com/login">Sign in to GitHub</a> and <a href="https://github.com/up-for-grabs/up-for-grabs.net#list-your-project">check out the README.</a></li>
</ol>
</p>
16 changes: 7 additions & 9 deletions _includes/before.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ <h1><span class="header-inside">I want to get involved!</span></h1>
the load of working on open source projects.
</p>

<p>
Find a project you'd like to get involved with:
<p>Find a project you'd like to get involved with:</p>

<ul>
<li>Read the contributor guidelines of the project</li>
<li>Get the project running locally</li>
<li>Leave a message on a task you'd like to work on</li>
<li>Get to work!</li>
</ul>
</p>
<ul>
<li>Read the contributor guidelines of the project</li>
<li>Get the project running locally</li>
<li>Leave a message on a task you'd like to work on</li>
<li>Get to work!</li>
</ul>
2 changes: 1 addition & 1 deletion _includes/head.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<head>
<meta charset='utf-8' />
<meta http-equiv="X-UA-Compatible" content="chrome=1" />
<meta name="description" content="Want to contribute to open source, but not sure where to start?" />
<meta name="description" content="Want to contribute to open source, but not sure where to start? This is a list of projects which have curated tasks specifically for new contributors. These are a great way to get started with a project, or to help share the load of working on open source projects." />
<meta property="og:url" content="https://up-for-grabs.net" />
<meta property="og:title" content="Up For Grabs" />
<meta property="og:description" content="Want to contribute to open source, but not sure where to start?" />
Expand Down
3 changes: 1 addition & 2 deletions _includes/header.html
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<a id="view-mode-a" title="dark-mode"><img id="view-mode" src="/images/Dim-Night.png"/></a>
<header>

<header role="banner">
<a id="forkme_banner" href="https://github.com/up-for-grabs/up-for-grabs.net">View on GitHub</a>
<div class="container">
<a id="go-back-home-a" href="/#/"><img id="go-back-home" src="{{ site.github.url }}/images/logo.png" alt="Up For Grabs"></a>
Expand Down
104 changes: 53 additions & 51 deletions _includes/scripts.html
View file
Original file line number Diff line number Diff line change
@@ -1,59 +1,61 @@
<script type="text/html" id="projects-panel-template">
<div class="filters-panel cf">
<label class="filter-label" for="project">Filter by last updated:</label>
<div class="radio-btn-row">
<div class="radio-btn-wrapper">
<button id="1week" class="radio-btn" type="button">1 Week</button>
</div>
<div class="radio-btn-wrapper">
<button id="1month" class="radio-btn" type="button">1 Month</button>
</div>
<div class="radio-btn-wrapper">
<button id="6months" class="radio-btn" type="button">6 Months</button>
</div>
<div class="radio-btn-wrapper">
<button id="1year" class="radio-btn" type="button">1 Year</button>
</div>
<div class="radio-btn-wrapper">
<button id="2years" class="radio-btn" type="button">2 Years</button>
<menu>
<div class="filters-panel cf">
<label class="filter-label" for="project">Filter by last updated:</label>
<div class="radio-btn-row">
<div class="radio-btn-wrapper">
<button id="1week" class="radio-btn" type="button">1 Week</button>
</div>
<div class="radio-btn-wrapper">
<button id="1month" class="radio-btn" type="button">1 Month</button>
</div>
<div class="radio-btn-wrapper">
<button id="6months" class="radio-btn" type="button">6 Months</button>
</div>
<div class="radio-btn-wrapper">
<button id="1year" class="radio-btn" type="button">1 Year</button>
</div>
<div class="radio-btn-wrapper">
<button id="2years" class="radio-btn" type="button">2 Years</button>
</div>
</div>
</div>
</div>
</div>

<div class="filters-panel cf">
<label class="filter-label" for="project">Filter by name:</label>
<select class="names-filter" id="project" multiple data-placeholder="Select a project..." >
<% _.each(names, function(entry, key){ %>
<div class="filters-panel cf">
<label class="filter-label" for="project">Filter by name:</label>
<select class="names-filter" id="project" multiple data-placeholder="Select a project..." >
<% _.each(names, function(entry, key){ %>
<option value="<%-key%>"><%- entry.name%></option>
<% }) %>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" for="label">Filter by label: </label>
<select class="labels-filter" id="label" multiple data-placeholder="Select a label..." >
<% _.each(labels, function(entry, key){ %>
<option value="<%-key%>"><%- entry.name%></option>
<% }) %>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" for="label">Filter by label: </label>
<select class="labels-filter" id="label" multiple data-placeholder="Select a label..." >
<% _.each(labels, function(entry, key){ %>
<option value="<%-key%>"><%- entry.name%></option>
<% }) %>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" for="tag">Filter by tags: </label>
<select class="tags-filter" id="tag" multiple data-placeholder="Select a tag..." >
<% _.each(tags, function(entry, key){ %>
<option value="<%-entry.name%>"><%- entry.name%> (<%-entry.frequency%>)</option>
<% }) %>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" >Popular tags:</label>
<ul class="popular-tags">
<% _.each(popularTags, function(entry, key){ %>
<li>
<a title="Popular Tag: <%-entry.name%>" tabindex="0"><%-entry.name%> <span class="popular-tags__frequency">(<%-entry.frequency%>)</span></a>
</li>
<% }) %>
</ul>
</div>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" for="tag">Filter by tags: </label>
<select class="tags-filter" id="tag" multiple data-placeholder="Select a tag..." >
<% _.each(tags, function(entry, key){ %>
<option value="<%-entry.name%>"><%- entry.name%> (<%-entry.frequency%>)</option>
<% }) %>
</select>
</div>
<div class="filters-panel cf">
<label class="filter-label" >Popular tags:</label>
<ul class="popular-tags">
<% _.each(popularTags, function(entry, key){ %>
<li>
<a title="Popular Tag: <%-entry.name%>" tabindex="0"><%-entry.name%> <span class="popular-tags__frequency">(<%-entry.frequency%>)</span></a>
</li>
<% }) %>
</ul>
</div>
</menu>
<div class="projects">
<% let count=0 %>
<% _.each(projects, function(project) { %>
Expand Down
12 changes: 6 additions & 6 deletions index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
layout: default
---

<div class="block">
<section id="i-want-to-get-involved" class="block">
{% include before.html %}
</div>
<div class="block">
</section>
<article id="projects" class="block">
<h1><span class="header-inside">Projects</span></h1>
<div id="projects-panel">
{% include noscript.html %}
</div>
</div>
<div class="block">
</article>
<section id="i-maintain-a-project" class="block">
{% include after.html %}
</div>
</section>

0 comments on commit cb4919e

Please sign in to comment.