Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caching stats in project output on build #1346

Merged
merged 5 commits into from Sep 30, 2019
Merged

caching stats in project output on build #1346

merged 5 commits into from Sep 30, 2019

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 23, 2019 •
edited

Resolves #1329
Resolves #261
Closes #1369

  • run the update stats action against all the projects
  • tweak the template for each project to look for this stats object and add the number

You can see this live at the Netlify deploy URL: https://deploy-preview-1346--up-for-grabs-test-bench.netlify.com/

Before I can go live with this, I need to do a bunch of things:

  • extract first commit into own PR
  • wire up new action to open a PR which will update these stats
  • find a way to add a tooltip with the last updated field (using a quick "relative time" function)
  • hide projects from results which have 0 cached issues (different case to "unknown")
  • test updating stats again today
  • move action to run at a different hour each day so it won't clash with project cleanup work

@shiftkey shiftkey force-pushed the demo-cached-stats-in-project branch 2 times, most recently from fc72593 to e332fc9 Compare September 23, 2019 23:38
This was referenced Sep 23, 2019
Closed
Closed
@shiftkey shiftkey changed the title demo: caching stats in project output on build caching stats in project output on build Sep 26, 2019
@shiftkey shiftkey mentioned this pull request Sep 26, 2019
Closed
@shiftkey shiftkey force-pushed the demo-cached-stats-in-project branch 3 times, most recently from 0af9722 to d27aadc Compare September 27, 2019 14:08
@shiftkey shiftkey mentioned this pull request Sep 27, 2019
Closed
shiftkey
shiftkey commented Sep 27, 2019
View reviewed changes
Copy link
Member Author

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding some context to the review not captured by the commits

_includes/scripts.html Show resolved Hide resolved
javascripts/main.js Show resolved Hide resolved
javascripts/projectsService.js Show resolved Hide resolved
@ritwik12 ritwik12 added needs review discussion open-ended issues that haven't yet defined what needs to be worked on labels Sep 30, 2019
ritwik12
ritwik12 approved these changes Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@ritwik12 ritwik12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go with this, Thanks for an amazing work here @shiftkey

@shiftkey shiftkey merged commit 7dacf40 into gh-pages Sep 30, 2019
@shiftkey shiftkey deleted the demo-cached-stats-in-project branch September 30, 2019 12:56
This was referenced Oct 2, 2019
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritwik12 ritwik12 ritwik12 approved these changes

Assignees

@ritwik12 ritwik12

Labels
discussion open-ended issues that haven't yet defined what needs to be worked on
Projects
None yet
Milestone
No milestone
2 participants
@shiftkey @ritwik12