Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render project links in index.html #564

Closed

Conversation

christianp
Copy link
Contributor

At the moment, the project data is held in JSON and the list is created
in javascript after the page loads. This breaks the site for users
without JS.

This moves the rendering of the project list to index.html, so it's
included in the static page, and then the renderProjects() function
shows/hides and reorders the projects as necessary.

If the JS doesn't run, you just see the complete list of projects in the
default order, without the filter interface.

This somewhat conflicts with #525, which assumes that the page is unusable if JS isn't supported.

At the moment, the project data is held in JSON and the list is created
in javascript after the page loads. This breaks the site for users
without JS.

This moves the rendering of the project list to index.html, so it's
included in the static page, and then the renderProjects() function
shows/hides and reorders the projects as necessary.

If the JS doesn't run, you just see the complete list of projects in the
default order, without the filter interface.
@shiftkey
Copy link
Member

shiftkey commented Apr 17, 2017

@christianp this looks pretty great. The only regression I can notice here is that we no longer get the benefit of randomizing the project list on the client - this code - and we're now doing thing alphabetically.

@christianp
Copy link
Contributor Author

@shiftkey is it really a regression? When the JS runs, the list is shuffled. I can't see how you'd shuffle the list per-client without JS, and on gh-pages.

@dahlbyk
Copy link
Member

dahlbyk commented Apr 25, 2017

It's a regression in that the top projects now get disproportionate exposure. If JS is available, we could suppress the HTML project list until we're able to shuffle it.

@shiftkey shiftkey self-assigned this Jun 27, 2019
@shiftkey shiftkey added needs work Reviewer has indicated changes need to be make to this pull request before it can be merged and removed needs review labels Jun 27, 2019
@shiftkey shiftkey removed their assignment Jun 27, 2019
@shiftkey
Copy link
Member

Dropping this back to need-work because there are outstanding conflicts, and this changes the behaviour of the site to no longer randomize the list of projects.

@shiftkey
Copy link
Member

shiftkey commented Oct 5, 2019

I'm going to close this out because #1412 is ready for discussion about a simpler first step to improve the experience for clients with JavaScript disabled.

@shiftkey shiftkey closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work Reviewer has indicated changes need to be make to this pull request before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants