Add tests #53
Merged
Add tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekhtiari
reviewed
Apr 17, 2023
tests/test_quality_metrics.py
Outdated
|
|
||
| def test_rmse(test_array1, test_array2): | ||
| rmse = quality_metrics.rmse(test_array1, test_array2) | ||
| assert float(rmse) == 0.0636659786105156 |
There was a problem hiding this comment.
since we might encounter precision issues (lots of number after decimal point), I would recommend using sth like assert_almost_equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: Added unit tests.
Todo: Remove dependency on
rasterioas it depends ongdalbindings, which is a dependency hell