Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add before route enter restrictions to settings page #294

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Aug 3, 2020

Description

Fixes issue #292

Reason for this PR

  • Bugfix, settings page had no route enter restrictions

Changes in this PR

  • add the same restrictions as for public profiles, as all logged in users have the permission to reach it

Type of change (remove all that don't apply)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Firefox

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • Deployed develop version 0.5.0

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added bug Something isn't working vue labels Aug 3, 2020
@tobias-wiese tobias-wiese merged commit a028b21 into develop Aug 3, 2020
@tobias-wiese tobias-wiese deleted the bugfix/settingspage_enter_restrictions branch August 3, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants