Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filter accounts by role #302

Merged
merged 10 commits into from
Aug 4, 2020

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Aug 4, 2020

Description

Implements issue #262

Reason for this PR

  • The admin did not have any possibility to filter the accounts, he gets from the backend

Changes in this PR

  • I added a simple filter bar consisting of buttons, that allow to filter the shown accounts. To do so, the object containing all users (gotten from the API call in the account list) is just filtered, s.t. no additional API calls like getAdmins are needed. The filter is set outside the suspense wrapper of the account list itself, s.t. refreshing the account list does not reset the selected filter.

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • OS: Windows

  • Browser: Firefox Chrome

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • Deployed master version 0.5.0

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Screenshot:

grafik

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Aug 4, 2020
@tobias-wiese tobias-wiese merged commit 61b5fbd into develop Aug 4, 2020
@tobias-wiese tobias-wiese deleted the feature/filter_accounts_by_role branch August 4, 2020 14:37
@tobias-wiese tobias-wiese mentioned this pull request Aug 4, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants