Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api user 0.5.2 #352

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Feature/api user 0.5.2 #352

merged 5 commits into from
Aug 14, 2020

Conversation

bastihav
Copy link
Collaborator

Description

Implements user service API v0.5.2
Implements #329

Reason for this PR

  • The reasons for the API change were, that we had to fetch every lecturer individually, which was a big performance overhead.

Changes in this PR

  • Add new API methods and already implement them in the course list

Type of change (remove all that don't apply)

  • Refactoring
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran the unit tests against backend development
  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Chrome

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • Deployed develop version

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@bastihav bastihav merged commit 21ff24e into develop Aug 14, 2020
@bastihav bastihav deleted the feature/api-user-0.5.2 branch August 14, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants