Feature/test speedup #523
Merged
Feature/test speedup #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastihav
approved these changes
Sep 28, 2020
Comment on lines
42
to
47
| var today = new Date(); | ||
| var monthPadded = ("00" + (today.getMonth() + 1)).substr(-2); | ||
| var dayPadded = ("00" + today.getDate()).substr(-2); | ||
| var random2 = Math.floor(Math.random() * 999).toString(); | ||
| var randomPadded = ("000" + random2).substr(-3); | ||
| student.matriculationId = monthPadded + dayPadded + randomPadded; |
There was a problem hiding this comment.
we should add a method for this in a helper "getRandomMatriculationId()"
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reason for this PR
Changes in this PR
Type of change (remove all that don't apply)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: (remove all that don't apply)