-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Management #755
Conversation
not yet working as API returns <empty string>
fix a small bug with current semester immatriculation check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall that is great work.
For the E2E we should propagate the id from the parent component into the base-input component for properly getting them via Cypress. Otherwise, it looks like the following:
I would suggest something like
In the parent:
<base-input identifier="WhatEverIdYouWant" ..../>
and stting the input field's id via the prop in the BaseInput.vue
<input :id="identifier" .../>
Additionally we must not forget to rework the error message assertation in the E2E tests
Consider closing #354 on merge (or connecting it) |
@bastihav this is just an idea, not tested. Feel free to revert or change
Description
WIP:
Dependency update
Type of change (remove all that don't apply)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
OS: Windows Mac Linux
Browser: Firefox Chrome Safari Chromium
Frontend: (remove all that don't apply)
Backend: (remove all that don't apply)
Checklist: (remove all that don't apply)