Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Info Page Module Names #795

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Jan 18, 2021

Description

Reason for this PR

Changes in this PR

  • add an API call for fetching modules via the moduleIds given in the course object and construct the display string for the search-select component with id and name of the fetched modules

Type of change (remove all that don't apply)

  • Refactoring
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Firefox

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed development build

Checklist: (remove all that don't apply)

  • I adapted corresponding E2E tests (especially for bugfixes)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Screenshot:

grafik

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Jan 18, 2021
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
@tobias-wiese tobias-wiese merged commit 7d09dc2 into develop Jan 25, 2021
@tobias-wiese tobias-wiese deleted the feature/module_names_courseInfoPage branch January 25, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Module name in course info page for student
2 participants