Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show enrollment id secret #856

Merged
merged 7 commits into from
Feb 18, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Feb 15, 2021

Description

Reason for this PR

Changes in this PR

  • add secret in deleteOwnAccount modal and request data section

Type of change (remove all that don't apply)

  • Refactoring
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed development build

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Feb 15, 2021
@tobias-wiese tobias-wiese changed the title Feature/show enrollement id secret Feature/show enrollment id secret Feb 15, 2021
@tobias-wiese tobias-wiese self-assigned this Feb 18, 2021
Copy link
Collaborator

@bastihav bastihav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
both fields should have the same size (height at least), also text size should be the same.

src/components/modals/DeleteOwnAccountModal.vue Outdated Show resolved Hide resolved
@tobias-wiese tobias-wiese merged commit e670e82 into develop Feb 18, 2021
@tobias-wiese tobias-wiese deleted the feature/show_enrollementIdSecret branch February 18, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show enrollmentIdSecret to user
2 participants