Add 6 aws appmesh services #147
Conversation
|
/test-examples="examples/appmesh/gatewayroute.yaml,examples/appmesh/route.yaml,examples/appmesh/virtualgateway.yaml,examples/appmesh/virtualnode.yaml,examples/appmesh/virtualrouter.yaml,examples/appmesh/virtualservice.yaml" |
There was a problem hiding this comment.
Hi @svscheg,
I see we have switched from using config.TemplatedStringAsIdentifier to config.IdentifierFromProvider for the external-name configurations of these resources. I believe you had a debugging session with @sergenyalcin because I saw the issue #134 and the comment in the description of the issue #11.
This causes duplications in the API such as the name fields. Normally, we would like to normalize the APIs. Do we have any insights into why we had to use config.IdentifierFromProvider configuration for these resources?
| spec: | ||
| - backend: | ||
| - virtualService: | ||
| - virtualServiceName: servicea.simpleapp.local |
There was a problem hiding this comment.
Could you please include the dependencies of each resource in its own example manifest file? We would like to be able to test these manifests individually. I will also trigger uptest on each of these manifests so that we can detect missing dependencies.
There was a problem hiding this comment.
dependencies is present for all examples.
|
/test-examples="examples/appmesh/gatewayroute.yaml" |
|
/test-examples="examples/appmesh/route.yaml" |
|
/test-examples="examples/appmesh/virtualgateway.yaml" |
|
/test-examples="examples/appmesh/virtualnode.yaml" |
|
/test-examples="examples/appmesh/virtualrouter.yaml" |
|
/test-examples="examples/appmesh/virtualservice.yaml" |
|
/test-examples="examples/appmesh/gatewayroute.yaml" |
|
/test-examples="examples/appmesh/route.yaml" |
|
/test-examples="examples/appmesh/virtualnode.yaml" |
|
/test-examples="examples/appmesh/virtualservice.yaml" |
1 similar comment
|
/test-examples="examples/appmesh/virtualservice.yaml" |
There was a problem hiding this comment.
Hi @svscheg,
Thank you for working on these resources. @ezgidemirel will detail the root cause of switching to config.IdentifierFromProvider in the associated issue.
svscheg
force-pushed
the
add-aws-appmesh-services
branch
from
8a0abf5
to
4be3a20
Compare
|
/test-examples="examples/appmesh/gatewayroute.yaml" |
|
/test-examples="examples/appmesh/route.yaml" |
|
/test-examples="examples/appmesh/virtualgateway.yaml" |
|
/test-examples="examples/appmesh/virtualnode.yaml" |
|
/test-examples="examples/appmesh/virtualrouter.yaml" |
|
/test-examples="examples/appmesh/virtualservice.yaml" |
Description of your changes
Moving 6 resources in the
appmeshgroup:aws_appmesh_virtual_gatewayaws_appmesh_virtual_nodeaws_appmesh_virtual_routeraws_appmesh_virtual_serviceaws_appmesh_gateway_routeaws_appmesh_routeFixes #11
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually and with the following uptest runs:
aws_appmesh_virtual_gateway: https://github.com/upbound/provider-aws/actions/runs/3472586833/jobs/5803608548
aws_appmesh_virtual_node: https://github.com/upbound/provider-aws/actions/runs/3473998426/jobs/5806660014
aws_appmesh_virtual_router: https://github.com/upbound/provider-aws/actions/runs/3472596038/jobs/5803629456
aws_appmesh_virtual_service: https://github.com/upbound/provider-aws/actions/runs/3469713419/jobs/5797035712
aws_appmesh_gateway_route: https://github.com/upbound/provider-aws/actions/runs/3473783926/jobs/5806206430
aws_appmesh_route: https://github.com/upbound/provider-aws/actions/runs/3473996622/jobs/5806656187