Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the registry value in the autodiscovery for helm #1346

Closed
mavimo opened this issue May 26, 2023 · 0 comments · Fixed by #1347
Closed

Add support for the registry value in the autodiscovery for helm #1346

mavimo opened this issue May 26, 2023 · 0 comments · Fixed by #1347
Milestone

Comments

@mavimo
Copy link
Contributor

mavimo commented May 26, 2023

Is your feature request related to a problem?

I'm experimenting the auto-discovery feature helm.

I see that work fine using the tag and repository entry but only if the repository include also the registry entry, when they are defined in different entries (that seems to be the most used approach) is not able to work.

E.g.:

image:
    tag: 1.0.0.
    repository: quay.io/foo/bar

work fine, but:

image:
    tag: 1.0.0.
    registry: quay.io
    repository: foo/bar

fail since use the default registry (hub.docker.io) instead the one specified in the registry.

Solution you'd like

Add support also for the registry entry

Alternatives you've considered

Do some manipulation in the yaml before and after using updatecli to woraround the problem

Anything else?

I already have some code working, I'll open a PR soon

mavimo added a commit to mavimo/updatecli that referenced this issue May 26, 2023
@mavimo mavimo changed the title Feature Request: Add support for the registry value in the autodiscovery for helm May 26, 2023
mavimo added a commit to mavimo/updatecli that referenced this issue May 26, 2023
mavimo added a commit to mavimo/updatecli that referenced this issue May 26, 2023
mavimo added a commit to mavimo/updatecli that referenced this issue May 26, 2023
mavimo added a commit to mavimo/updatecli that referenced this issue May 26, 2023
@olblak olblak added this to the 0.52.0 milestone May 27, 2023
olblak pushed a commit that referenced this issue May 27, 2023
…e for helm (#1347)

* #1346: Implement the support for registry in the autodiscovery feature for helm

* #1346: sluggify source/condition/target keys

* #1346: fix tests that are using the renamed folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants