Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit message with appropriated value #100

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Fix commit message with appropriated value #100

merged 2 commits into from
Oct 20, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 20, 2020

Fix #96

@olblak olblak added the bug Something isn't working label Oct 20, 2020
jetersen
jetersen approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, such a simple fix. I should have looked myself 😢

Sorry for creating extra work for you! 😅

@olblak olblak merged commit 4f51ca1 into master Oct 20, 2020
@olblak olblak deleted the issues/96 branch November 18, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the commit message seems to be off
2 participants
@olblak @jetersen