[condition] Support multiple files with in conditions of kind file
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
olblak
approved these changes
Dec 9, 2022
olblak
added
enhancement
|
I'm updating the title to have a better changelog item (I'll follow the associated issue RFE title). Thanks a lot @macedogm ! |
dduportal
changed the title
file
olblak
changed the title
filefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the limitation for multiple files in conditions, fix related tests that are failure validation to allow more than one element in 'Files' and add a passing test for such scenario.
Fix #1026
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
Signed-off-by: Guilherme Macedo guilherme.macedo@suse.com