Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart OCI support #1029

Merged
merged 16 commits into from
Dec 16, 2022
Merged

Add Helm Chart OCI support #1029

merged 16 commits into from
Dec 16, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Dec 10, 2022

Fix #811

  • Add OCI support to Helm Resource
  • Add OCI support for Helmfile autodiscovery
  • Add OCI support for Helm autodiscovery

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request source condition Modify condition resource resource-helmchart Resource of kind Helm Chart helmfile resource-helm labels Dec 10, 2022
@olblak olblak marked this pull request as draft December 10, 2022 09:03
olblak and others added 2 commits December 10, 2022 10:05
@olblak olblak marked this pull request as ready for review December 13, 2022 08:08
olblak and others added 9 commits December 13, 2022 09:13
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak
Copy link
Member Author

olblak commented Dec 15, 2022

I temporary commented the OCI integration tests.
ghcr.io doesn't allow anonymous query to ghcr.io and I don't have yet image available on dockerhub

since I am planning to build and publish an oci helm chart for updatemonitor which requires a bit of work.
I am planning to merge this PR as is then come back later to fix the tests.

@olblak olblak merged commit bb510c5 into updatecli:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
condition Modify condition resource enhancement New feature or request helmfile resource-helm resource-helmchart Resource of kind Helm Chart source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add OCI registry support to helm resource
1 participant