Only set git auth if both username && password are specified #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
|
Merging for now so e2e pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Gitea e2e started failing a week or two ago.
I first noticed it on
try.gitea.io.I assumed it was due to that service being an unstable one so I moved the test to codeberg but the same issue appeared yesterday.
After some quick testing, I noticed that configuring http auth with no username/password would trigger errors
This PR only set http auth if both username&password are defined
Test
To test this pull request, you can run the following commands:
go build -o bin/updatecli . ./bin/updatecli diff --config e2e/updatecli.d/success.d/gitea/scm.yaml --debug --clean=trueAlso did some testing with private repo and it works as expected
Additional Information
Tradeoff
Potential improvement
Similarly to the Github scm, I am wondering if the username is needed