-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source][condition] Add Cargo Package support #1081
Conversation
Waow nice, I am glad to see you manage to create a new resource without reaching out for help :D |
No problem, I've remove all the git handling, I had not understood the scm concept fully. I'm adapting the description as well to remove the tradeoff |
We use this linter https://golangci-lint.run/ that detect a bunch of minor errors |
Coud I also ask you to add an manifest to |
I think it's missing the part where you dowload the index from the crate.io repository. I just tested the following manifest
and I get
This makes me think you may want to download the repository in the temporary directory created by Updatecli |
Yes I think so. clone the crate.io repository in the temporary directory created by Updatecli |
Excepted a few minor remark, I think this pullrequest is really great. Not in this pull request but a follow up effort would be to improve the git clone operation . I think some benchmarking is needed to speed up. I never realize how slow it could be for large repositories |
I've adapted the behaviour regarding the default index. The package now support the following spec:
The behaviour to fetch a package data becomes:
|
Super excited to see this pullrequest. |
Implement a new plugin to support cargo packages
This PR allows using Cargo Package as a source and a condition.
By default, it will use
crates.io
index repository, but a private repository can be used as wellTest
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement